Thanks for the patch. I've applied it and pushed it to 'next' http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=84b49be8f02aaf230164163a39c09049ed9f306d
By the way: git format-patch -1 is the perfect way to submit a patch for us to apply, especially an easy one like this. It makes it a breeze to apply it, build and test it locally first, and then push it to our stage and merge to 'next'. Thanks!! On Wed, Aug 15, 2012 at 12:05 PM, Marcin Wojdyr <[email protected]> wrote: > OK > > I don't know how you usually exchange patches, i'm attaching a patch > made by git format-patch > > Not tested > > M > > On 15 August 2012 16:30, David Cole <[email protected]> wrote: >> Yes... the script only did one-line occurrences. If you'd like to submit a >> hand-made patch to remove the rest, we'd take it... >> >> :-) >> >> >> On Wed, Aug 15, 2012 at 11:27 AM, Marcin Wojdyr <[email protected]> wrote: >>> >>> I was looking into git history of one file and just noticed this: >>> >>> commit 9db3116226cb99fcf54e936c833953abcde9b729 >>> Author: Kitware Robot <[email protected]> >>> Date: Mon Aug 13 13:50:14 2012 -0400 >>> >>> Remove CMake-language block-end command arguments >>> >>> >>> fyi: the script only removed single-line arguments. >>> A few multiline args are left, e.g.: >>> >>> [wojdyr@dt Modules]$ grep -rP 'endif *\([^)]' . >>> ./FindGTK.cmake: endif(GTK_gtk_INCLUDE_PATH >>> ./CMakeDetermineCXXCompiler.cmake:endif (CMAKE_CROSSCOMPILING >>> ./CMakeFindBinUtils.cmake:endif("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC" >>> ./CMakeDetermineCCompiler.cmake:endif (CMAKE_CROSSCOMPILING >>> >>> >>> Marcin >>> -- >>> >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Please keep messages on-topic and check the CMake FAQ at: >>> http://www.cmake.org/Wiki/CMake_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://www.cmake.org/mailman/listinfo/cmake >> >> -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
