On Sun, 2013-11-17 at 20:03 +0200, Raphael Kubo da Costa wrote: > Roy Crihfield <rscr...@gmail.com> writes: > > > I have a patch the the CMake emacs mode I'd like to have reviewed and > > push. What is the preferred way to do this - should I just send the > > patch, or fork and push to the repository? > > Both sending a patch to cmake-devel via `git patch' and sending a pull > request with GitHub should work fine.
I haven't created a patch for it, but the keymap provided with cmake mode needs to be changed: (defvar cmake-mode-map (let ((map (make-sparse-keymap))) (define-key map "\C-ch" 'cmake-help-command) (define-key map "\C-cl" 'cmake-help-list-commands) (define-key map "\C-cu" 'unscreamify-cmake-buffer) map) "Keymap used in cmake-mode buffers.") This is not good: All keys C-c <letter> are reserved for users for their local commands and are not supposed to be mapped by any other modes. >From the "Tips" section of the Emacs Lisp manual, second bullet: > Don't define C-c _letter_ as a key in Lisp programs. Sequences > consisting of C-c and a letter (either upper or lower case) are > reserved for users; they are the only sequences reserved for users, so > do not block them. > Changing all the Emacs major modes to respect this convention was a > lot of work; abandoning this convention would make that work go to > waste, and inconvenience users. Please comply with it. http://www.gnu.org/software/emacs/manual/html_node/elisp/Key-Binding-Conventions.html Cheers! -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake