Hello,
I make a patch (against maint branch) to allow detection of:
...<DartMeasurement...>...</DartMeasurement>...
Instead of only:
<DartMeasurement...>...</DartMeasurement>
Where can I add some documentation related to this ?
Best regards,
YC
----- Mail original -----
De: "ycollette nospam" <[email protected]>
À: "David Cole" <[email protected]>
Cc: [email protected]
Envoyé: Mercredi 30 Juillet 2014 18:07:08
Objet: Re: [CMake] Ctest and custom measurements
OK, I will try to make a patch.
YC
----- Mail original -----
De: "David Cole" <[email protected]>
À: "ycollette nospam" <[email protected]>
Cc: [email protected]
Envoyé: Mercredi 30 Juillet 2014 17:42:07
Objet: Re: [CMake] Ctest and custom measurements
> By the way, this should be better documented in the cmake / ctest
> documentation.
> And we should be allowed to add measurements like these in the log:
> Log message - date - <DartMeasurement ...>0.1</DartMeasurement>
I agree on both points. I would go even farther and say what you were
trying to do originally should have "just worked"...
> Do I fill a bug report for this ?
You can. Although it would be more effective if you could contribute a
patch to improve the docs, or to implement the code required to improve
the DartMeasurement parsing so it's not necessarily at the beginning of
the line, or even to accept "NamedMeasurement" values directly from the
output...
Are you able to submit patches that do any of this? Do you have the
time or the inclination?
:-)
David C.
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake
diff --git a/Source/CTest/cmCTestTestHandler.cxx b/Source/CTest/cmCTestTestHandler.cxx
index 497774d..c44d630 100644
--- a/Source/CTest/cmCTestTestHandler.cxx
+++ b/Source/CTest/cmCTestTestHandler.cxx
@@ -410,12 +410,12 @@ cmCTestTestHandler::cmCTestTestHandler()
this->LogFile = 0;
- // regex to detect <DartMeasurement>...</DartMeasurement>
+ // regex to detect ...<DartMeasurement>...</DartMeasurement>...
this->DartStuff.compile(
- "(<DartMeasurement.*/DartMeasurement[a-zA-Z]*>)");
- // regex to detect each individual <DartMeasurement>...</DartMeasurement>
+ "(.*<DartMeasurement.*/DartMeasurement[a-zA-Z]*>.*)");
+ // regex to detect each individual ...<DartMeasurement>...</DartMeasurement>...
this->DartStuff1.compile(
- "(<DartMeasurement[^<]*</DartMeasurement[a-zA-Z]*>)");
+ "(.*<DartMeasurement[^<]*</DartMeasurement[a-zA-Z]*>.*)");
}
//----------------------------------------------------------------------
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake
