>>>>> "Peter" == Peter Denno <[EMAIL PROTECTED]> writes:
Peter> ;;;-----------------------------------
Peter> REGARDING: DEBUG (type H for help) -- (spread out over too many lines).
Peter> ;;; /usr/local/lisp/cmucl/src/code/debug.lisp:
Peter> (defun internal-debug ()
Peter> (let ((*in-the-debugger* t)
Peter> (*read-suppress* nil))
Peter> (unless (typep *debug-condition* 'step-condition)
Peter> (clear-input *debug-io*)
Peter> (format *debug-io* "~2&Debug (type H for help)~2%")) <--------
Peter> #-mp (debug-loop)
Peter> #+mp (mp:without-scheduling (debug-loop))))
Peter> SUGGESTION: Remove the line entirely, use fewer newlines, or create a
variable
Peter> in ext: to allow the user to stop it from printing.
I'm opposed to deleting this line.
Peter> -----------------------------------
Peter> REGARDING: RESTARTS: -- (extra lines above it)
Peter> ;;; /usr/local/lisp/cmucl/src/code/debug.lisp:
Peter> (defun show-restarts (restarts &optional (s *error-output*))
Peter> (when restarts
Peter> (format s "~&Restarts:~%") <----------------------
[snip]
Peter> SUGGESTION: Remove ~& from the format directive.
~& only puts in a newline if the printer thinks we're not at the
beginning of a new line. Harmless.
[snip]
Peter> (defun finish-error-output (source-info won) <--------------
Peter> (declare (type source-info source-info))
Peter> (compiler-mumble "~&; Compilation ~:[aborted after~;finished in~] ~A.~&"
Peter> won
Peter> (elapsed-time-to-string
Peter> (- (get-universal-time)
Peter> (source-info-start-time source-info))))
Peter> (undefined-value))
Peter> SUGGESTION: I suppose it is because of some bootstrapping issue that
setting
Peter> *compile-verbose* has no effect. I suggest: Remove the first
compiler-mumble
Peter> ("Python version...") entirely. In the second, don't bother with the time.
Peter> Remove (compiler-mumble "~%"). Remove finish-error-output entirely.
I for one want to see a compilation aborted message.
Peter> -----------------------------------
Peter> REGARDING: Excessive newlines before errors.
Peter> /usr/local/lisp/cmucl/src/code/:
Peter> (defun print-simple-error (condition stream)
Peter> (format stream "~&~@<Error in function ~S: ~3i~:_~?~:>"
<----------------
Peter> (condition-function-name condition)
Peter> (simple-condition-format-control condition)
Peter> (simple-condition-format-arguments condition)))
Peter> SUGGESTION: Remove ~& Also, warnings are introduced with "Warning:".
Perhaps
Peter> this should use "Error:"
The ~& is harmless. I don't know, warnings are warnings and errors
are errors. I don't quite follow.
Peter> -----------------------------------
Peter> REGARDING: Inconsistency in error messages.
Peter> Most error messages begin with "Error" but the messages in PCL do not. (but
Peter> see above)
Peter> SUGGESTION: Add "Error:" in PCL error messages.
Yes, should probably fix that.
Peter> -----------------------------------
Peter> REGARDING: Default values of global variables related to verbosity.
Peter> The current settings might be nice for cmucl developers, but the rest of us
Peter> (who are also less likely to know about these) probably don't want all that
Peter> stuff. I suggest:
Peter> (defvar *gc-verbose* nil) ; In ./code/gc.lisp or ./code/gengc.lisp
Newbies should know things are consing.
Peter> (defvar ext::*top-level-auto-declare* t) ; In ./code/eval.lisp
Newbies should know what happens when you define things at toplevel
and wonder why things don't behave the same anymore. (I've been
bitten by this many times when I just wanted to do something quick and
named a variable X, which is also used on other code.)
Anyway, those are my opinions.
Ray
