This was spotted by one of our users, the network snippet does not render 
correctly with static IP's defined the ks renders as

$ cobbler system --name=fred getks | grep ^network
network --bootproto=dhcp --hostname=fred --device=eth1 --onboot=on
network --bootproto=dhcp --hostname=fred --device=eth0 --onboot=on

after patch

$ cobbler system --name=fred getks | grep ^network
network --bootproto=static --ip=x.x.x.x --netmask=255.255.255.0 
--gateway=x.x.x.x --nameserver=x.x.x.x hostname=fred --device=eth1 --onboot=on
network --bootproto=static --ip=x.x.x.x --netmask=255.255.254.0 
--gateway=x.x.x.x --nameserver=x.x.x.x --hostname=fred --device=eth0 --onboot=on

I think this should be a boolean, not a string check ?


--- a/snippets/network_config
+++ b/snippets/network_config
@@ -38,7 +38,7 @@
                 #set $i = $i + 1
             #end if
             #if $mac != "" or $ip != "" and $is_vlan == "false"
-                #if $static == "True":
+                #if $static == True:
                     #if $ip != "":
                         #set $network_str = "--bootproto=static"
                         #set $network_str = $network_str + " --ip=" + $ip

 

Cheers,
Simon
_______________________________________________
cobbler-devel mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/cobbler-devel

Reply via email to