Hi,

It looks like this hunk:

-    if not codes.RE_IPV4_ADDRESS.match(addr):
-        raise CX("Invalid IPv4 address format")
+    if not netaddr.valid_ipv4(addr):
+        raise CX("Invalid IPv4 address format (%s)" % addr)
+
+    if not netaddr.IPAddress(addr).is_hostmask():
+        raise CX("Invalid IPv4 host address (%s)" % addr)
+
+    return addr

is_hostmask returns True for basically the inverse of a netmask. So it
seems wrong to check for this for host addresses?

Thanks,
Nish

_______________________________________________
cobbler-devel mailing list
cobbler-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/cobbler-devel

Reply via email to