Javier Palacios wrote: > Just a few fast remarks > > >> Looking at it again, the archmap stuff should really not be in there. >> Basically what we need here is the bare minimum patch to add "cobbler >> import" ability to scan Debian, without changing or cleaning up any of >> the existing stuff. >> > > The archmap stuff is there just to replace existing changes in arch names > coming from command line or from the imported trees. It's no problem > to leave the original code there (although I obviously believe that the map > is cleaner, besides the ugly trick of the empty string value). >
It did a bit more than that -- it changed behavior from the way cobbler used to work -- "Fedora i386" imported as "Fedora x86", for instance, even if the arch was set correctly to i386 to correspond with the tree. I would suggest doing the bare minimum to support Debian imports rather than trying to fix this -- it requires much less debugging and testing when we start with a base that's known to work and then just apply a minimal patch. > >> For reference, here's one of the import use cases that I found broken: >> >> make devinstall && make eraseconfig && cobbler import --name=RHEL3U3 >> --mirror=/mnt/engarchive2/released/RHEL-3/U3/AS/ --available-as=http://foo >> > > Is it possible to get a copy of that tree ? When I run `make test`, everything > goes right, although the included repos are quite limited. > [Actually I need to remove acl related things. Do I need some extra package, > or might that code not be commited] > This is not part of "make test", but the result of running the import command above. That tree is pretty huge, but you can simulate it by having several DVD's exploded in the same root. "make test" does not do large imports like that because not everyone will have access to the same tree. > >> (eraseconfig is a new target that just creates a clean cobbler install) >> > > Regarding that target, I believe there is a bug in the Makefile. It cares > about > /var/lib/cobbler/distro* and similar things, but I think what it searchs for > is > actually /var/lib/cobbler/config/distro* > Not a bug. The makefile is set to ignore commands that fail and try two possibilities. serializer_catalog (the new default) uses /var/lib/cobbler/config/distros.d/* serializer_yaml (the old default) uses /var/lib/cobbler/distros This is configured in modules.conf, though most people will never need to change the setting. It cleans them both out so there's no copy of either. --Michael _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
