Michael DeHaan wrote:
> Harry Hoffman wrote:
>   
>> Doh!
>>
>>   [EMAIL PROTECTED] repo_mirror]# cobbler report
>>
>>   BootAPI instance has no attribute 'report'
>>     File "/usr/lib/python2.4/site-packages/cobbler/cobbler.py", line 77, 
>> in main
>>       rc = BootCLI().run(sys.argv)
>>
>>     File "/usr/lib/python2.4/site-packages/cobbler/cobbler.py", line 57, 
>> in run
>>       return self.loader.run(args)
>>
>>     File "/usr/lib/python2.4/site-packages/cobbler/commands.py", line 
>> 116, in run
>>       return fn.run()
>>
>>     File 
>> "/usr/lib/python2.4/site-packages/cobbler/modules/cli_report.py", line 
>> 115, in run
>>       print self.api.report(report_what = self.options.what, report_name 
>> = self.options.name, \
>>
>>
>> But cobbler sync works correctly now :-)
>>
>> Cheers,
>> Harry
>>
>>
>> Michael DeHaan wrote:
>>   
>>     
>>> Ordinarily I wouldn't drop a fix so quickly, but seeing this is a fix 
>>> for a fix:
>>>
>>> http://git.fedorahosted.org/git/?p=cobbler;a=commitdiff;h=29ff4468dfb9289e490442bea6d95f995677bea8
>>> http://people.fedoraproject.org/~mdehaan/files/cobbler/
>>>
>>> I'll update the builders shortly.
>>>
>>> --Michael
>>>
>>>
>>>
>>> _______________________________________________
>>> cobbler mailing list
>>> [email protected]
>>> https://fedorahosted.org/mailman/listinfo/cobbler
>>>     
>>>       
>> _______________________________________________
>> cobbler mailing list
>> [email protected]
>> https://fedorahosted.org/mailman/listinfo/cobbler
>>   
>>     
>
> Indeed, that report patch should /not/ be applied to master.
>
> I will sort this out shortly, thanks.
>
> --Michael
>
>
>
> _______________________________________________
> cobbler mailing list
> [email protected]
> https://fedorahosted.org/mailman/listinfo/cobbler
>   

As I suspected, the problem was that cli_report.py, which was /not/ 
packaged in git (rightfully so), was left over from a previous aborted 
patch and was built into this RPM. The fix is:

rm /usr/lib/python2.X/site-packages/cobbler/modules/cli_report.py

I'll work at fixing the RPM. Shouldn't be long...

(Meanwhile, the next thing I want to add is to make sure "make test" and 
the RPM build target builds from a clean checkout each time so as to not 
allow any files not in git from entering into the rpms)

--Michael

_______________________________________________
cobbler mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/cobbler

Reply via email to