> (B) Having a default for the item_distro.py values is a good thing, > because if no argument is passed to "distro add" it can assume a > reasonable default. At least for now redhat based distros constitute > at least 95% of all cobbler usage. Yes, we do want this to change, but
The pre'sence or values for distro defaults have no impact in the import code. Just don't apply the patch to item_distro.py would suffice. I'll keep the empty defaults on my devel copy, and clean them from future patch submissions. > (C) Can you explain why the get_pxe_arch function, which was there to > return the architecture of a specific point in the directory tree where > the kernel+initrd is found, now returns a list? Are these architecture > guesses? I can't see any ability for sharing of kernels between arches. Basically, they return an array to list every arch found, when learn_arch_from_tree is invoked. At least for debian, multiple arches can live in the same media or repository, and returning the first one might cause inconsistency. Later on I realized that it is a method to guess the archs supported at the imported media, and that the list can be checked against command line args (for example) to also increase consistency, although that's only on the way. Although the behaviour is exactly the same than the old one when only an architecture is found, the old behaviour is easy to recover, raising an exception if multiple arches found and return just the first item, so turning unnecesary the for loop on the get_pxe_arch call, Javier Palacios _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
