Partha Aji wrote: > I have questions on 3 fix mes that I have to implement > > # FIXME: missing code to ensure TFTP is enabled > # FIXME: missing code to configure firewall (???) > # FIXME: missing code to ensure cobblerd, httpd, xinetd is > chkconfig on > > I was wondering if I could simply use the cobbler check logic found in > cobbler.cobbler.action_check to do the validation for TFTP enabled and > configuring firewall.
It checks to see if they are enabled but it does not configure them, so this will not be sufficient. For tftp-server, basically it will need to be a simple sed invocation or equivalent. You should ask before doing this. I would not auto-configure the firewall as that may not be what the admin desires. I won't like it anyway. > Secondly are we sure about wanting chkconfig on > for those services right (I thought sysadmins were wary of those > things).. A cobbler install with httpd and cobblerd chkconfig off is quite broken, especially for Spacewalk purposes. > I was also confused on when to do Subprocess.call( shell=True) vs (shell > = False). I currently use Shell = False unless the thing barfed saying > can;t execute the child process in which case I 'd go for shell = True > . I had to do shell = True for for '/sbin/service cobblerd restart', > and "/sbin/service httpd restart" .. shell=False does not take string arguments, it takes a list, where the first argument in the list is the full path to the script/binary. > I added the logic to check return > codes and cease execution if it failed.. Please review the attached > patches when you have time and apply them accordingly.. I'll meanwhile > work on doing the TFTP enablement checks... > > PS: > I was wondering if you were ok with autogenerating the modules.conf & > settings files when they install the cobbler RPM. > For example we can have a post script that runs > '/usr/bin/cobbler-setup -a > /usr/share/cobbler/installer_templates/defaults' > This will make the templates the defacto place to add all the new config > entries... This would break .rpmnew, .rpmsave functionality in RPM, so it would not be a good option. > You can add the default values to installer_templates/defaults > That way we don't need keep installer_templates/modules.conf.template in > sync with config/modules.conf... Please let me know what you think of > the idea... Thanks for the reviews in the last commit.. > > Partha > _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
