Jeroen van Meeuwen wrote: > Michael DeHaan wrote: > >> Jeroen van Meeuwen wrote: >> >>> Sorry for the trailing whitespace foo in this patch, a sane patch would >>> look like this: >>> >>> >> Jeroen, >> >> Can you supply more in-depth information about what this patch does, >> specifically? >> >> Examples would be good. >> >> > > Sure, this is a FIXME in the devel branch's code, which concerns finding > more then just one type of vmlinuz/initrd.img in the tree we're walking; > > # FIXME: If there are more than one kernel or initrd image on the same > # directory, results are unpredictable > > I found that with a layout like for F-10-Beta; > > [EMAIL PROTECTED] pxeboot]$ pwd > /data/os/distr/fedora/releases/test/10-Beta/Fedora/i386/os/images/pxeboot > [EMAIL PROTECTED] pxeboot]$ ll > total 58244 > -rw-r--r-- 1 537 537 20398080 2008-09-25 18:50 efiboot.img > -rw-r--r-- 1 537 537 16749126 2008-09-25 18:50 initrd.img > -rw-r--r-- 1 537 537 16805609 2008-09-25 18:53 initrd-PAE.img > -rw-r--r-- 1 537 537 265 2008-09-25 18:50 README > -rw-r--r-- 2 537 537 2763536 2008-09-25 18:50 vmlinuz > -rw-r--r-- 1 537 537 2814192 2008-09-25 18:53 vmlinuz-PAE > > Only the PAE version of vmlinuz/initrd gets imported. > > The key became to store all vmlinuz/initrd's found, and matching any > combination of a initrd-PAE.img vs. a vmlinuz-PAE, but luckily no matter > what is in the file name, both initrd's and vmlinuz's sort the same > (e.g. the first initrd in the list will match with the first vmlinuz, > the second... and so forth). > > -Jeroen > _______________________________________________ > cobbler mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/cobbler >
Thanks for the explanation, this sounds like a good thing to have -- I'll review this shortly. --Michael _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
