Michael DeHaan wrote: > Vreman, Peter - Acision wrote: > >>>>> If the system delete code works out well, I take it you're going to >>>>> >>>>> >>> make >>> >>> >>>>> all the other object deletes work the same way? >>>>> >>>>> This seems like it would be very nice for batch deletes. >>>>> >>>>> >>>>> >>>> The batch operations functionality is the main reason why I created the >>>> >>>> >>> patch. >>> >>> >>>> The patch can be extended to include all other types >>>> >>>> >>> profiles/distros/images the same way. But before to continue with the >>> other types it is better to agree on how the actions will be presented to >>> the user. I quickly made a hack with the buttons because it was easy. But >>> there might be other ideas for the presentation. >>> >>> It depends how the buttons look. Image buttons are ok, just doing anchor >>> tags with javascript actions also preserves space. I assume we're >>> talking about a row of checkboxes and an "apply" at the bottom, rather >>> than one button for each system that does all the calls when it is >>> clicked? >>> >>> >>> >>>> Shall I submit a new patch with the spaces fixed? >>>> >>>> >>> Yes, please do. Thanks! >>> >>> >> Attached. >> >> Peter >> >> >> >> This e-mail and any attachment is for authorised use by the intended >> recipient(s) only. It may contain proprietary material, confidential >> information and/or be subject to legal privilege. It should not be copied, >> disclosed to, retained or used by, any other party. If you are not an >> intended recipient then please promptly delete this e-mail and any >> attachment and all copies and inform the sender. Thank you. >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> cobbler mailing list >> [email protected] >> https://fedorahosted.org/mailman/listinfo/cobbler >> > > Hey Peter, > > Ok, looks like a very good start and /very/ useful. I have a few > suggestions that could make this a bit more usable, I think, and they > are all just presentation related. > > Currently there's a row of buttons on the top of the page. Some depend > on what is selected, some allow multi selections, some do not. I think > that is a bit confusing, or it was to me at least. > > What I would recommend is that: > -- The "Add" feature only be available from the left hand side sidebar > as it was before after your first couple of patches. > -- An action like "Copy" or "Rename" that can only take one at a time be > shown on each line, with each system record. Let's do the same with > edit, so you have on each line: > -- For multi-select options, move those buttons to the bottom of the > list and make some header called "batch actions" that shows > -- Remove the "edit" link that surrounds the system name and move it to > a button > > If I may show this in really bad ASCII diagrams: > > | System: | Edit Button | Template: > | View Rendered: | Copy | Rename > checkbox | systemname1 | edit | kickstart template | > rendered kickstart | copy button | rename button | > checkbox | systemname2 | edit | kickstart template | > rendered kickstart | copy button | rename button | > checkbox | systemname3 | edit | kickstart template | > rendered kickstart | copy button | rename button | > checkbox | systemname4 | edit | kickstart template | > rendered kickstart | copy button | rename button | > > Correction, remove "kickstart template" from the above. per-system-templates are a fringe feature and don't need to show up there.
> (empty space) > > batch actions on checked systems: > power control | netboot status | delete > > Basically that would give it just a little bit better idea of whether > clicking a button would do that particular action to the particular > system or would be a batch action. > > Also if we do that we can remove the "Edit/Rename" logic from the > system_edit pages along with the delete buttons on those pages. > > I would definitely be interested in seeing that. > > Thanks! > > --Michael > > > > > > > > _______________________________________________ > cobbler mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/cobbler > _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
