Darryl L. Pierce wrote:
> On Mon, Dec 22, 2008 at 02:37:43PM -0500, Michael DeHaan wrote:
>   
>> I think we can be more explicit WRT the "if protocol is not supplied" 
>> based on only supporting what koan can support today:
>>
>> The valid forms are:
>>
>> nfs://hostspec:/path_not_ending_in_slash
>> hostspec can be either "u...@host" or "host".
>>     
>
> It can also be user:passw...@host to include authentication
> details[1], though probably not a good idea to put it into 
> the clear like that.
>
>   
>> the literal "nfs://" is required for this format.
>>     
>
> I'll add a check for that as well. If auth details are provided then
> a hostname and a protocol must be provided.
>
>   

Specifically what I'm getting at is there's only one protocol, so we can 
mention that in the error message.

>> /absolute_path_not_ending_in_slash
>>     
>
> Well, for an image record, there needs to be a filename provide,
> right? Therefore, a missing filename would be an exception. Or do
> you mean something else?
>  
>   

That's what I mean, if it ends in slash, we know for sure it's a 
directory but cannot do more validation without mounting it, which we 
don't want to do.

>> I'm not sure what the port details were? Where would a port be supplied?
>>     
>
> If the hostname is followed by a : then a port is *supposed* to be
> provided or else the : should be excluded/ignored[2]. 
>   

Hostname followed by a slash could be followed by a mount point, so I 
guess what you're saying is there could be yet another colon.
> [1] http://labs.apache.org/webarch/uri/rfc/rfc3986.html#userinfo
> [2] http://labs.apache.org/webarch/uri/rfc/rfc3986.html#port
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> cobbler mailing list
> [email protected]
> https://fedorahosted.org/mailman/listinfo/cobbler
>   

_______________________________________________
cobbler mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/cobbler

Reply via email to