Axel Thimm wrote: > Hi, > > there are a few typos in the script making some code paths bail out: > --- /var/lib/cobbler/snippets/post_install_network_config~ 2008-12-19 > 18:17:37.000000000 +0200 > +++ /var/lib/cobbler/snippets/post_install_network_config 2008-12-30 > 18:21:58.000000000 +0200 > @@ -35,5 +35,5 @@ > ## setup bonding if we have to > #if $numbondingdevs > 0 > -if [-x "/etc/modprobe.conf"]; then; > +if [-x "/etc/modprobe.conf"]; then > echo "options bonding max_bonds=$numbondingdevs" >> /etc/modprobe.conf > fi > @@ -89,5 +89,5 @@ > ## Rename this interface in modprobe.conf > ## FIXME: if both interfaces startwith eth this is wrong > -if [-x "/etc/modprobe.conf"]; then; > +if [-x "/etc/modprobe.conf"]; then > grep \$IFNAME /etc/modprobe.conf | sed "s/\$IFNAME/$iname/" >> > /etc/modprobe.conf.cobbler > grep -v \$IFNAME /etc/modprobe.conf >> /etc/modprobe.conf.new > @@ -222,5 +222,5 @@ > mv /etc/sysconfig/network-scripts/cobbler/* /etc/sysconfig/network-scripts/ > rm -r /etc/sysconfig/network-scripts/cobbler > -if [-x "/etc/modprobe.conf"]; then; > +if [-x "/etc/modprobe.conf"]; then > cat /etc/modprobe.conf.cobbler >> /etc/modprobe.conf > rm -f /etc/modprobe.conf.cobbler > > > ------------------------------------------------------------------------ > > _______________________________________________ > cobbler mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/cobbler >
Yep, absolutely correct -- and also reported a bit earlier :) We'll get this cleaned up next week and pushed out as a 1.4.1 release so it doesn't suprise too many new people. We definitely like installs being fully automated out of the box without intervention. Thanks! --Michael _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
