John Eckersberg wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jasper Capel wrote: > | Hi, > | > | Previous patch applied cleanly to devel, so here it is for the devel > branch: > | > https://bender.newnewyork.nl/git/gitweb.cgi?p=cobbler/.git;a=commit;h=30a862700654238d4b255875c7eae1dfadabe20d > | > | git://bender.newnewyork.nl/cobbler (branch: devel-bugs) > | > | Cheers, > | Jasper > > There's still an assumption in cli_system.py that eth0 is the default > interface: > > ~ # if we haven't said what interface we are editing, it's eth0. > > ~ if self.options.interface: > ~ my_interface = self.options.interface > ~ else: > ~ my_interface = "eth0" > > This is why I had originally put the default_interface code in. > Currently if you are doing a system operation and you do not specify > '--interface' it will default to eth0. If you delete eth0, you would > have no way to choose a sane default, unless there was only one > interface, then you could just pick that one. I guess it's not a big > deal to always have to manually specify between two or more interfaces > which are not named eth0, but it's something to be aware of here. > > - -- > John Eckersberg > IT Engineering Support > Red Hat, Inc. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org > > iEYEARECAAYFAkl/IloACgkQdxt4pd4ztYsjAQCcDTQnkTPL+Zx2IiV35DH9UbTZ > PtYAnjT2QbXJp/Wi0CU9zEest6pbXL78 > =cQhM > -----END PGP SIGNATURE----- > _______________________________________________ > cobbler mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/cobbler >
--interface describes what interface you want to edit, so I don't find this terrible for it to have a getopt default. Yep, something to be aware of. I think if anyone is doing something strange enough to delete eth0 they would probably want a better view of their interfaces via CobblerWeb anyway. --Michael _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
