Jasper Capel wrote: > Hi, > > The network snippets didn't render anymore on master, this had two > reasons: > - Name server search snippet patches were applied on master, we don't > have name server search properties on master, so there variables didn't > exist > Thanks! > - I think the new YAML implementation changed the $interface.static type > to boolean instead of string. Booleans don't have .lower(), so this > failed. >
It's possible that it's coercing string values of 'true' or something to booleans. Except, you know, they should really be booleans anyway. So perhaps the old implementation was saving booleans as strings. Ultimately this does mean we need to test all of the fields more to ensure all booleans "work", but it's the right thing to do. > Patches, as usual, to be found on git://bender.newnewyork.nl/cobbler > Branches: master-bugs and devel-bugs. (Patches (actually, reverts) for > the first issue were only applied to master, as we do have name server > search stuff in devel). > > http://bender.newnewyork.nl/git/gitweb.cgi?p=cobbler/.git;a=shortlog;h=refs/heads/master-bugs > > Another question: debugging snippets is a PITA at the moment, if it > fails, it just shows $SNIPPET('post_install_network_config'). Is there > anything we can do about this? > > Possibly. Snippets are essentially mapped to Cheetah includes. If we could have them expand out to the Cheetah error message instead for that particular snippet that seems useful. I'm not sure offhand how much work that would take, but it's worth looking into. Might be somewhat slower, but I'm not sure it would be noticeable. The trick is when doing this to make sure we don't tweak snippet evaluation behavior. > -Jasper > > ------------------------------------------------------------------------ > > _______________________________________________ > cobbler mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/cobbler > _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
