Cool -- I tested out your patch here and it looks good. Lets get this pushed to mainline if possible.
-Chris On Fri, Sep 25, 2009 at 3:53 PM, Bill Peck <[email protected]> wrote: > Michael DeHaan wrote: > > On 09/22/2009 10:26 AM, Christopher Johnston wrote: > >> Behavior on 1.6.x allows you to zero out any params as part of a > >> kopt. I noticed in 2.0 I can append more entries but cant remove the > >> existing ones or remove all of them. Also is kopts-post even valid > >> anymore? I don't see it printed when looking at a system report, but > >> I see it in the json file. If the usual CLI sequence that I am used > >> to is different now please feel free to chime in. > >> > >> # cobbler system edit --name=host --kopts="debug=1" > >> # cobbler system report host | grep options > >> kernel options : {'debug': '1'} > >> kernel options post : {} > >> # cobbler system edit --name=host --kopts="" > >> # cobbler system report host | grep options > >> kernel options : {} > >> kernel options post : {} > >> > >> 2.0 behavior: > >> > >> # cobbler system report --name=host | grep Kernel > >> Kernel Options : {'igb.LLISize': '128', > >> 'igb.LLIPush': '1', 'mtos_nic': '1', 'pinirq': '1'} > >> # cobbler system edit --name=host --kopts='' > >> # cobbler system report --name=host | grep Kernel > >> Kernel Options : {'igb.LLISize': '128', > >> 'igb.LLIPush': '1', 'mtos_nic': '1', 'pinirq': '1'} > >> > >> > >> > >> ------------------------------------------------------------------------ > >> > >> _______________________________________________ > >> cobbler mailing list > >> [email protected] > >> https://fedorahosted.org/mailman/listinfo/cobbler > >> > > > > Indeed, it seems to be doing --in-place by default in the CLI. Can > > you see that there is a Trac item open on this? > > > > --Michael > > I believe I have fixed this in my git repo. > > > http://fedorapeople.org/gitweb?p=bpeck/public_git/cobbler.git;a=blobdiff;f=cobbler/remote.py;h=c803dbb4886041a0b27bfefecf4b2993f341835b;hp=6688bd3404ca84d97ed5adefc7c28bdae2bb5878;hb=f693fe08b587a3617506ae380f58471e9ad1ca57;hpb=6150cc70b9b0381ed1344495bf1bb4d144f9932a > > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > cobbler mailing list > > [email protected] > > https://fedorahosted.org/mailman/listinfo/cobbler > > > > _______________________________________________ > cobbler mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/cobbler >
_______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
