From: Márton Németh <[email protected]> The id_table field of the struct pci_driver is constant in <linux/pci.h> so it is worth to make pci_device_id also constant.
The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by: Márton Németh <[email protected]> Cc: Julia Lawall <[email protected]> Cc: [email protected] --- diff -u -p a/drivers/hwmon/via686a.c b/drivers/hwmon/via686a.c --- a/drivers/hwmon/via686a.c 2009-12-03 04:51:21.000000000 +0100 +++ b/drivers/hwmon/via686a.c 2010-01-03 20:55:10.000000000 +0100 @@ -767,7 +767,7 @@ static struct via686a_data *via686a_upda return data; } -static struct pci_device_id via686a_pci_ids[] = { +static const struct pci_device_id via686a_pci_ids[] = { { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4) }, { 0, } }; _______________________________________________ Cocci mailing list [email protected] http://lists.diku.dk/mailman/listinfo/cocci (Web access from inside DIKUs LAN only)
