From: Márton Németh <[email protected]> The id_table field of the struct usb_device_id is constant in <linux/usb.h> so it is worth to make ds_id_table also constant.
The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by: Márton Németh <[email protected]> Cc: Julia Lawall <[email protected]> Cc: [email protected] --- diff -u -p a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c --- a/drivers/w1/masters/ds2490.c 2009-12-03 04:51:21.000000000 +0100 +++ b/drivers/w1/masters/ds2490.c 2010-01-08 07:52:31.000000000 +0100 @@ -170,7 +170,7 @@ struct ds_status }; -static struct usb_device_id ds_id_table [] = { +static const struct usb_device_id ds_id_table[] = { { USB_DEVICE(0x04fa, 0x2490) }, { }, }; _______________________________________________ Cocci mailing list [email protected] http://lists.diku.dk/mailman/listinfo/cocci (Web access from inside DIKUs LAN only)
