On Mon, 12 Apr 2010, Corentin Chary wrote:

> > It looks fine to me, and it works fine for me as well.  I get as the
> > complete output:
> >
> > init_defs_builtins: /usr/local/share/coccinelle/standard.h
> > acpi_evaluate_object without kfree: tests/acpi.c 3
> > no modification on the input file
> >
> > The no modification on the input file just means that nothing was
> > modified.  The python code shows that something was matched.
> >
> > julia
> >
> 
> I think I found the reason, most of the acpi_evaluate_object calls are
> in this form:
> 
> acpi_status status;
> 
> status = acpi_evaluate_object();
> 
> So I just modified my .cocci file like that and now it works :)
> 
> @r@
> expression E;
> expression R;
> position p;
> @@
> 
> R = acpi_evaluate_object(..., &E);@p
> ... when != kfree(E.pointer)

OK.  You could also have left out the semicolon in the original version.

julia
_______________________________________________
Cocci mailing list
[email protected]
http://lists.diku.dk/mailman/listinfo/cocci
(Web access from inside DIKUs LAN only)

Reply via email to