Hi, On Wednesday 07 July 2010 13:04:36 Michal Marek wrote: > On 3.7.2010 21:49, Nicolas Palix wrote: > > Hi, > > > > On Saturday 03 July 2010 17:20:34 Kulikov Vasiliy wrote: > >> Use $KBUILD_EXTMOD instead of $srctree when the latter is not null > >> to use make M=somedir. > >> > >> Signed-off-by: Kulikov Vasiliy <[email protected]> > >> --- > >> scripts/coccicheck | 8 +++++++- > >> 1 files changed, 7 insertions(+), 1 deletions(-) > >> > >> diff --git a/scripts/coccicheck b/scripts/coccicheck > >> index b8bcf1f..7d66a55 100755 > >> --- a/scripts/coccicheck > >> +++ b/scripts/coccicheck > >> @@ -1,5 +1,11 @@ > >> #!/bin/sh > >> > >> +if [ -n "$KBUILD_EXTMOD" ]; then > >> + CHECK_DIR="$KBUILD_EXTMOD" > >> +else > >> + CHECK_DIR="$srctree" > >> +fi > >> + > >> SPATCH="`which ${SPATCH:=spatch}`" > >> > >> if [ "$C" = "1" -o "$C" = "2" ]; then > >> @@ -64,7 +70,7 @@ coccinelle () { > >> echo ' http://coccinelle.lip6.fr/' > >> echo '' > >> > >> - $SPATCH -D $MODE $FLAGS -sp_file $COCCI $OPT -dir $srctree || exit 1 > >> + $SPATCH -D $MODE $FLAGS -sp_file $COCCI $OPT -dir $CHECK_DIR || exit 1 > >> else > >> $SPATCH -D $MODE $FLAGS -sp_file $COCCI $OPT $OPTIONS || exit 1 > >> fi > >> > > > > In doing so, the output of the patch mode will produce patches relative to > > $KBUILD_EXTMOD. > > I am not sure of what most of developers want but if the patches must be > > relative to > > the Linux kernel root, the following patch must be used. > > If you are checking your out-of-tree module, then you're probably not > going to send the resulting patch to lkml. >
Indeed. I thus acked the original patch last Monday [1]. Thanks. [1] http://lkml.org/lkml/2010/7/5/136 > Michal > -- Nicolas Palix Tel: (+33) 1 44 27 87 25 Tel: (+33) 6 81 07 91 72 Web: http://www.diku.dk/~npalix/ _______________________________________________ Cocci mailing list [email protected] http://lists.diku.dk/mailman/listinfo/cocci (Web access from inside DIKUs LAN only)
