Hello, I packaged this version for Debian and I found some problems:
1. The tarball contains some generated pyc files, it will be good if they will be deleted in the next version. 2. When using external libraries build system tries to compile /usr/lib/ocaml/pycaml/pycaml.ml. It is because /usr/lib/ocaml/pycaml/ is included in search path for depend target. Attached patch tries to fix this. I hope it works in case of bundled pycaml but I did not test it. 3. During compilation of files with ocaml scripts spatch passes the following include options to the compiler: -I /usr/lib/ocaml -I /usr/share/coccinelle/ocaml -I /usr/share/coccinelle/parsing_c -I /usr/share/coccinelle/commons but .../parsing_c and .../commons are not installed. Also compilation of ocaml2.cocci fails with this error: Error: Unbound value Ast_c.unwrap Regards, Eugeniy Meshcheryakov 24 липня 2010 о 10:20 +0200 Julia Lawall написав(-ла): > Version 0.2.3 s released. There are no changes as compared to 0.2.3rc6. > > julia > _______________________________________________ > Cocci mailing list > [email protected] > http://lists.diku.dk/mailman/listinfo/cocci > (Web access from inside DIKUs LAN only)
Index: coccinelle/python/Makefile
===================================================================
--- coccinelle.orig/python/Makefile 2010-07-24 22:26:58.929645502 +0200
+++ coccinelle/python/Makefile 2010-07-24 22:31:31.736183497 +0200
@@ -32,12 +32,14 @@
SOURCES= pycocci_aux.ml pycocci.ml
+INCLUDEDIRS_LOCAL = ../commons ../commons/ocamlextra ../globals \
+ ../parsing_c ../parsing_cocci
+
ifeq ("$(PYCAMLDIR)", "pycaml")
-INCLUDEDIRS = ../commons ../commons/ocamlextra ../globals ../$(PYCAMLDIR) \
- ../parsing_c ../parsing_cocci
+INCLUDEDIRS_LOCAL += ../$(PYCAMLDIR)
+INCLUDEDIRS = $(INCLUDEDIRS_LOCAL)
else
-INCLUDEDIRS = ../commons ../commons/ocamlextra ../globals $(PYCAMLDIR) \
- ../parsing_c ../parsing_cocci
+INCLUDEDIRS = $(INCLUDEDIRS_LOCAL) $(PYCAMLDIR)
endif
SYSLIBS = str.cma unix.cma pycaml.cma
@@ -48,6 +50,7 @@
##############################################################################
INCLUDES=$(INCLUDEDIRS:%=-I %) $(INCLUDESEXTRA)
+INCLUDES_DEPEND=$(INCLUDEDIRS_LOCAL:%=-I %) $(INCLUDESEXTRA)
##############################################################################
# Generic ocaml variables
@@ -57,7 +60,7 @@
OCAMLCFLAGS ?= -g -dtypes
OCAMLC =ocamlc$(OPTBIN) $(OCAMLCFLAGS) $(INCLUDES)
OCAMLOPT = ocamlopt$(OPTBIN) $(OPTFLAGS) $(INCLUDES)
-OCAMLDEP = ocamldep$(OPTBIN) $(INCLUDES)
+OCAMLDEP = ocamldep$(OPTBIN) $(INCLUDES_DEPEND)
##############################################################################
signature.asc
Description: Digital signature
_______________________________________________ Cocci mailing list [email protected] http://lists.diku.dk/mailman/listinfo/cocci (Web access from inside DIKUs LAN only)
