Hello Julia,
On Thu, Sep 22, 2011 at 09:46:20PM +0200, Julia Lawall wrote:
> On Thu, 22 Sep 2011, Uwe Kleine-König wrote:
>
> > Hello Julia,
> >
> > On Fri, Aug 26, 2011 at 11:47:28AM +0200, Julia Lawall wrote:
> > > On Fri, 26 Aug 2011, Uwe Kleine-König wrote:
> > > > with the attached semantic patch coccinelle (from Debian; version
> > > > 0.2.5.deb-3) barfs with:
> > > >
> > > > ~/linux$ spatch -sp_file platform_device_register_full.cocci
> > > > arch/arm/plat-mxc/devices/platform-fec.c
> > > > init_defs_builtins: /usr/share/coccinelle/standard.h
> > > > 424 425
> > > > Fatal error: exception Failure("plus: parse error:
> > > > = File "platform_device_register_full.cocci", line 7, column
> > > > 62, charpos = 424
> > > > around = '{', whole content =
> > > > +platform_device_register_full(&((struct platform_device_info){ .name =
> > > > Ename, .id = Eid, .res = Eres, .num_res
> > > >
> > > > I admit not having tested a newer version of coccinelle, but scanning
> > > > the changelog suggests that this is not "fixed" in later versions.
> > > >
> > > > I havn't looked into coccinelle's code, but I imagine that it shouldn't
> > > > be too hard to add support for that construct given some knowledge of
> > > > the code.
> > > > I'd be happy to test patches that add support for that.
> > > >
> > > > Having said that it's entirely possible that I'm just unable to tell
> > > > coccinelle what I want from it, so suggestions to fix the semantic patch
> > > > are welcome, too, of course.
> > >
> > > No, it doesn't support them. I didn't know they existed :). But I see
> > > that they are supported by the C parser, so it should be easy to add
> > > them,
> > > although I don't think I have time today.
> > ping
>
> I thought I did this. Did you try the most recent rc?
>
> The changelog (which I notice is unreadable on the web page) says:
>
> - gcc constructors allowed in SmPL. Thanks to Uwe Kleine-Koenig for
> pointing out the problem.
No I don't, just stumbled over your reply while looking in my inbox and
didn't see a followup. I'll check and report.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
Cocci mailing list
[email protected]
http://lists.diku.dk/mailman/listinfo/cocci
(Web access from inside DIKUs LAN only)
