On Wed, 4 Apr 2012, ron minnich wrote:

Removing the ; after the S helps a little but ....

static void intel_init_display(struct drm_device *dev)
{
        struct drm_i915_private *dev_priv = dev->dev_private;
        int i;

        /* Returns the core display clock speed */
        if (IS_I945G(dev) || (IS_G33(dev) && ! IS_PINEVIEW_M(dev)))
                dev_priv->display.get_display_clock_speed =
                        i945_get_display_clock_speed;
        else if (IS_I865G(dev))
                dev_priv->display.get_display_clock_speed =
                        i865_get_display_clock_speed;
        else if (IS_I85X(dev))
                dev_priv->display.get_display_clock_speed =
                        i855_get_display_clock_speed;
        else /* 852, 830 */
                dev_priv->display.get_display_clock_speed =
                        i830_get_display_clock_speed;
        if (something) {
                printf("some\n");
        } else if (IS_I865G(dev)) {
                printf("testin\n");

}

@@
@@
-if (IS_I865G(...)) {...}
@@
statement S;
@@
-if (IS_I865G(...)) S

@@ -19,7 +19,5 @@ static void intel_init_display(struct dr
                        i830_get_display_clock_speed;
        if (something) {
                printf("some\n");
-       } else if (IS_I865G(dev)) {
-               printf("testin\n");
-       }
+       } else {}
}

it misses one of them ...

That one has an else, and there is no else in your pattern.

julia
_______________________________________________
Cocci mailing list
[email protected]
http://lists.diku.dk/mailman/listinfo/cocci
(Web access from inside DIKUs LAN only)

Reply via email to