On Sun, 23 Sep 2012, Eric Leblond wrote:
Hello, Thanks a lot Julia for your fast and efficient answer ! Le samedi 22 septembre 2012 à 19:08 +0200, Julia Lawall a écrit :A proposed patch that fixes this and some other trailing whitespace problems is attached. I still need to check that it does not break anything, so let me know if there are any new problems.First of all, it fixes the whitespace issue described in my previous mail. I've runned all my cocci test with this patch applied and no problem appears. I've only one issue left regarding formatting but this is dependant of my indentation style and can not be considered as a real problem. The issue is that the transformation modifies my indentation like shows in the following example: - if (new_pe == NULL) { - return NULL; - } + if (unlikely(new_pe == NULL)) + { + return NULL; + } I obtain a code which is not with the good coding style and need to be reindented. Is there a way to specify to coccinelle we want to use a specific model of indentation ?
To me, it looks like a bug, not a model of indentation. It should have put the first { where it was before, and then everything would have been OK. I'll take a look.
julia
_______________________________________________ Cocci mailing list [email protected] https://systeme.lip6.fr/mailman/listinfo/cocci
