On 11/08/2012 08:21 AM, Julia Lawall wrote:
How many cases do you find?
Well, only 2 cases (in drivers/iommu/tegra-smmu.c and fs/ceph/export.c).
It's worth noticing that the d_find_alias() function is only called 20
times though, so this seems to be quite a common mistake.
I attached an updated semantic patch, to deal with cases where the
dentry is assigned a new value and dput() has not been called.
WBR,
Cyril Roelandt.
//
// Make sure calls to d_find_alias() have a corresponding call to dput().
//
// Keywords: d_find_alias, dput
//
virtual context
virtual org
virtual patch
virtual report
@initialize:python depends on org || report@
msg = "Missing call to dput() at line %s."
@r exists@
local idexpression struct dentry *dent;
expression E, E1;
statement S1, S2;
position p1, p2;
@@
(
if (!(dent@p1 = d_find_alias(...))) S1
|
dent@p1 = d_find_alias(...)
)
<...when != dput(dent)
when != if (...) { <+... dput(dent) ...+> }
when != true !dent || ...
when != dent = E
when != E = dent
if (!dent || ...) S2
...>
(
return <+...dent...+>;
|
return @p2 ...;
|
dent@p2 = E1;
|
E1 = dent;
)
@depends on context@
local idexpression struct dentry *r.dent;
position r.p2;
@@
(
* return @p2 ...;
|
* dent@p2 = ...;
)
@script:python depends on org@
p1 << r.p1;
p2 << r.p2;
@@
coccilib.org.print_todo(p1[0], msg % (p2[0].line))
@depends on r && patch@
local idexpression struct dentry *r.dent;
position r.p2;
@@
(
+ dput(dent);
return @p2 ...;
|
+ dput(dent);
dent@p2 = ...;
)
@script:python depends on report@
p1 << r.p1;
p2 << r.p2;
@@
coccilib.report.print_report(p1[0], msg % (p2[0].line))
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci
