From: Markus Elfring <[email protected]> Date: Tue, 18 Nov 2014 09:27:16 +0100
The __pm_stay_awake() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- fs/eventpoll.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 7bcfff9..eec2e85 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -555,8 +555,7 @@ static inline void ep_pm_stay_awake(struct epitem *epi) { struct wakeup_source *ws = ep_wakeup_source(epi); - if (ws) - __pm_stay_awake(ws); + __pm_stay_awake(ws); } static inline bool ep_has_wakeup_source(struct epitem *epi) @@ -571,8 +570,7 @@ static inline void ep_pm_stay_awake_rcu(struct epitem *epi) rcu_read_lock(); ws = rcu_dereference(epi->ws); - if (ws) - __pm_stay_awake(ws); + __pm_stay_awake(ws); rcu_read_unlock(); } -- 2.1.3 _______________________________________________ Cocci mailing list [email protected] https://systeme.lip6.fr/mailman/listinfo/cocci
