Sorry, I missed this message.
On Wed, 21 Jan 2015, Eliseo Martínez wrote:
> Hi,
>
> From what I’ve read, I understand attributes are not supported by coccinelle.
> But I’m still wondering it there would be a way to perform a task I’d like to
> do: Checking whether functions marked as returning non-null are used in any
> place so that return value is checked for nullness/nonnullness.
> So, this breaks into 2 subproblems:
>
> 1) Matching desired functions.
>
> I know I can’t directly match functions having certain attributes.
> But we don’t use attributes directly. We use some macros for that.
> So, all functions I’d like to pick include the macro FUNC_ATTR_NONNULL_RET in
> their declaration/definition.
> Then, would there be any way to match functions having the literal
> “FUNC_ATTR_NONNULL_RET” in their declaration/definition?
Normally, a function header has the form
type name(T1 x1, ...)
If there are any terms outside of that pattern, parsing of the function
will simply fail. The way around this would be to add to standard.h the
following declaration:
#define FUNC_ATTR_NONNULL_RET
Then the occurrence of FUNC_ATTR_NONNULL_RET will be ignored. Neither
gives the inforation you want.
> 2) Applying some rules for the same set of functions.
>
> Up until now, I’ve done this by manually obtaining the list of desired
> functions, and then running this spatch:
>
> ```
> @@ identifier func =~
> "^(transstr|list_alloc|listitem_alloc|dict_alloc|dictitem_alloc|dictitem_copy|vim_strsave_fnameescape|ga_concat_strings|enc_canonize|reverse_text|get_tv_string|get_tv_string_buf|viminfo_readstring|ga_concat_strings_sep|xmalloc|xcalloc|xrealloc|xmallocz|xmemdupz|xstrchrnul|xmemscan|xstpcpy|xstpncpy|xstrdup|xstrndup|xmemdup|msg_show_console_dialog|home_replace_save|get_register|invocation_path_tail|concat_fnames|save_absolute_path|getroom|vim_strsave|vim_strnsave|vim_strsave_escaped|vim_strsave_escaped_ext|vim_strsave_shellescape|vim_strsave_up|vim_strnsave_up|strup_save|concat_str)$";
> statement S; @@
>
> (
> * if (func(...) == NULL) S;
> |
> * if (func(...) != NULL) S;
> )
>
> @@ identifier func =~
> "^(transstr|list_alloc|listitem_alloc|dict_alloc|dictitem_alloc|dictitem_copy|vim_strsave_fnameescape|ga_concat_strings|enc_canonize|reverse_text|get_tv_string|get_tv_string_buf|viminfo_readstring|ga_concat_strings_sep|xmalloc|xcalloc|xrealloc|xmallocz|xmemdupz|xstrchrnul|xmemscan|xstpcpy|xstpncpy|xstrdup|xstrndup|xmemdup|msg_show_console_dialog|home_replace_save|get_register|invocation_path_tail|concat_fnames|save_absolute_path|getroom|vim_strsave|vim_strnsave|vim_strsave_escaped|vim_strsave_escaped_ext|vim_strsave_shellescape|vim_strsave_up|vim_strnsave_up|strup_save|concat_str)$";
> identifier var; statement S; expression E; @@
>
> var = func(...);
> ... when != var = E
> (
> * if (var == NULL) S;
> |
> * if (var != NULL) S;
> )
> ```
>
> As you see, I have to replicate the list. Is there any better way to achieve
> the same effect?
I would not do this using a regular expression, but rather by matching and
then discarding the matches you don't like. In ocaml this would be:
@initialize:ocaml@
@@
let fns = "list of functions"
@r@
identifier func;
statement S;
position p;
@@
if (func@p() == NULL) S
@script:ocaml@
func << r.func;
p << r.p;
@@
if List.mem func fns
then do something
You can probably figure out how to do something similar in python. In this
way the list appears only once.
julia
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci
