Le 21/04/2015 22:16, Luis R. Rodriguez a écrit : > From: "Luis R. Rodriguez" <[email protected]> > > The driver doesn't use mtrr_add() or arch_phys_wc_add() but > since we know the framebuffer is isolated already on an > ioremap() we can take advantage of write combining for > performance where possible. > > In this case there are a few motivations for this: > > a) Take advantage of PAT when available > > b) Help with the goal of eventually using _PAGE_CACHE_UC over > _PAGE_CACHE_UC_MINUS on x86 on ioremap_nocache() (see commit > de33c442e titled "x86 PAT: fix performance drop for glx, > use UC minus for ioremap(), ioremap_nocache() and > pci_mmap_page_range()") > > Cc: Nicolas Ferre <[email protected]>
Seems okay: Acked-by: Nicolas Ferre <[email protected]> Thanks for having taking care of atmel_lcdfb driver. Bye, > Cc: Suresh Siddha <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: Juergen Gross <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Andy Lutomirski <[email protected]> > Cc: Dave Airlie <[email protected]> > Cc: Antonino Daplas <[email protected]> > Cc: Jean-Christophe Plagniol-Villard <[email protected]> > Cc: Tomi Valkeinen <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Luis R. Rodriguez <[email protected]> > --- > drivers/video/fbdev/atmel_lcdfb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/atmel_lcdfb.c > b/drivers/video/fbdev/atmel_lcdfb.c > index 94a8d04..abadc49 100644 > --- a/drivers/video/fbdev/atmel_lcdfb.c > +++ b/drivers/video/fbdev/atmel_lcdfb.c > @@ -1266,7 +1266,8 @@ static int __init atmel_lcdfb_probe(struct > platform_device *pdev) > goto stop_clk; > } > > - info->screen_base = ioremap(info->fix.smem_start, > info->fix.smem_len); > + info->screen_base = ioremap_wc(info->fix.smem_start, > + info->fix.smem_len); > if (!info->screen_base) { > ret = -ENOMEM; > goto release_intmem; > -- Nicolas Ferre _______________________________________________ Cocci mailing list [email protected] https://systeme.lip6.fr/mailman/listinfo/cocci
