On Mon, May 25, 2015 at 9:21 AM, Fabio Estevam <[email protected]> wrote: > On Mon, May 25, 2015 at 9:17 AM, Julia Lawall <[email protected]> wrote: >> On Mon, 25 May 2015, Fabio Estevam wrote: >> >>> The commit log should better describe the action that the patch will do. >>> >>> In this case we are 'adding' the pci_free_consistent. >> >> Not sure to follow the reasoning. The semantic patch doesn't add >> anything. > > Right, the semantich patch finds the missing pci_free_consistent, but > the generated patch is not finding pci_free_consistent. It is actually > adding the missing pci_free_consistent instead. > > So in the commit log of the generated patch, we should better use > 'add' instead of 'find'.
Ok, I understood it new. It is really just detecting the missing free calls. Please discard these two patches. _______________________________________________ Cocci mailing list [email protected] https://systeme.lip6.fr/mailman/listinfo/cocci
