On Fri, 21 Apr 2017, Andrea Grandi wrote:
> Hi Julia,
> Thanks a lot! This patch works great :)
>
>
> FYI, after applying the patch to remove the MACROs the compiler was
> complaining because the variable that was previously assigned the return
> value is now initialized.
> I have extended the patch to fix this compilation error and I ended up with
> the following:
>
> @bad_func_ret@
> statement S;
> position p;
> identifier virtual.FUNC;
> identifier r, f;
> @@
>
> r = f(..., FUNC(...)@S@p, ...);
>
>
> @@
> statement bad_func_ret.S;
> position bad_func_ret.p;
> identifier bad_func_ret.r;
> identifier virtual.RET;
> @@
>
> +#if 0
> S@p
> +#else
> +r = RET;
> +#endif
>
> @bad_func_ret2@
> statement S;
> position p;
> identifier virtual.FUNC;
> identifier r, f;
> @@
>
> r = FUNC(...)@S@p;
Try
r = <+... FUNC(...)@S@p ...+>
Then you should not need the first rule.
julia
>
>
> @@
> statement bad_func_ret2.S;
> position bad_func_ret2.p;
> identifier bad_func_ret2.r;
> identifier virtual.RET;
> @@
>
> +#if 0
> S@p
> +#else
> +r = RET;
> +#endif
>
>
>
> The two cases are required (?) to make sure that patch works both when the
> MACRO is used inside another function (case 1) or as a standalone function
> (case 2).
> There is some repetition, but it is still much better than my original
> patch!
>
> Thanks!
> Andrea
>
>
>
> On Thu, Apr 20, 2017 at 11:31 PM Julia Lawall <[email protected]> wrote:
>
>
> On Mon, 17 Apr 2017, Andrea Grandi wrote:
>
> > Hello!
> >
> > I am back porting a set of old header files into a recent
> version of my C
> > project. The old header files don't have the definition of
> various macros
> > (i.e. #define) that are currently used in the library. This is
> causing
> > various compilation errors.
> >
> > I'd like to use Coccinelle to place #if 0 around the
> expressions as a
> > temporary workaround in order to fix the compilation errors.
> >
> > I know it's a very powerful tool, but I have just started
> using it and I
> > would need some help writing the semantic patch.
> >
> > Here is a very simple example of what I have done so far:
> >
> > @@
> > identifier a;
> > expression P, N;
> > @@
> > -a = MACRO(P, N);
> > +// TODO: MACRO does not exist in old header
> > +#if 0
> > +a = MACRO (P, N);
> > +#endif
> > +a = 0;
> >
> > In some case, the macro is used inside a function call. In
> order to catch
> > this scenario I had to write something more verbose and less
> generic like:
> >
> > @@
> > expression E, D, err, P;
> > identifier f;
> > @@
> > -err = f(P, MACRO(E, 0), D);
> > +// TODO: MACRO does not exist in old header
> > +#if 0
> > +err = f(P, MACRO(E, 0), D);
> > +#endif
> > +err = OK;
> >
> > Finally, there are cases where the macro is used inside
> an if condition. For
> > example:
> >
> > if (a > MACRO(A, B)) {
> > // Various lines of code
> > }
> >
> > What I'd like to do here would be to put #if 0 around the
> whole block of
> > code.
> >
> > #if 0
> > if (a > MACRO(A, B)) {
> > // Various lines of code
> > }
> > #endif
> >
> > Is there a way in Coccinelle to cover all the three cases
> above with a
> > single expression?
>
> @bad@
> statement S;
> position p;
> @@
>
> MACRO(...)@S@p
>
> @@
> statement bad.S;
> position bad.p;
> @@
>
> +#if 0
> S@p
> +#endif
>
>
> >
> > Also, considering that I should replace a number of macros, is
> there a way
> > to create a generic semantic patch and use it multiple times
> by simply
> > providing different macro names? Sort of like calling a
> function multiple
> > times with different arguments.
>
> Replace the first rule by:
>
> @bad@
> statement S;
> position p;
> identifier virtual.MACRO;
> @@
>
> MACRO(...)@S@p
>
> Then on the command line, you can do -D MACRO=macro_name
>
> julia
>
>
>_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci
