On Fri, 12 May 2017, SF Markus Elfring wrote:
> > Maybe put parentheses around the second argument. An isomorphism will
> > drop them and you will avoid whatever parsing issue is being encountered.
>
> I do not observe a desired improvement after such a SmPL code adjustment.
Your change is not what I suggested either. The second argument starts to
the right of one comma and ends to the left of the next one.
julia
> @find@
> expression target;
> identifier action;
> @@
> target = action(...,
> ...
> * | __GFP_NOFAIL
> | (...),
> ...);
>
>
>
> The Coccinelle software does also not like a reduced script variant so far.
>
> @find@
> expression target;
> identifier action;
> @@
> target = action(...,
> ...
> * | __GFP_NOFAIL
> );
>
>
> elfring@Sonne:~/Projekte/Linux/next-patched> spatch.opt
> drivers/md/dm-region-hash.c
> ~/Projekte/Coccinelle/janitor/show_use_of_nofail_as_last_option1.cocci
> …
> minus: parse error:
> File
> "/home/elfring/Projekte/Coccinelle/janitor/show_use_of_nofail_as_last_option1.cocci",
> line 6, column 17, charpos = 87
> around = '...',
> whole content = ...
>
>
> Do you get further ideas?
>
> Regards,
> Markus
>
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci
