On Mon, 11 Jun 2018, Kees Cook wrote:
> On Mon, Jun 11, 2018 at 4:17 PM, Kees Cook <[email protected]> wrote:
> > Hi,
> >
> > I've been doing some large treewide changes to the allocators, and I
> > notice that Coccinelle does something odd for a specific case. I have
> > two scripts, one operating on kmalloc() and one operating on
> > devm_kmalloc(). They are identical script except for the function
> > names, however, while kmalloc produces patches like this:
> >
> > - foo = kmalloc(a * b, gfp);
> > + foo = kmalloc_array(a, b, gfp);
> >
> > the devm_kmalloc one produces:
> >
> > - foo = devm_kmalloc(handle, a * b, gfp);
> > + foo =devm_kmalloc_array(a, b, gfp);
> >
> > I can't figure out why the space after "=" is missing and have been
> > manually fixing it up...
I would need your semantic patch to see the problem.
> And while I'm at it... line breaks aren't working like I'd expect:
>
> - collection = kmalloc(sizeof(struct hid_collection) *
> - parser->device->collection_size * 2,
> GFP_KERNEL);
> + collection = kmalloc(array3_size(sizeof(struct
> hid_collection), parser->device->collection_size, 2),
> + GFP_KERNEL);
>
> Why wasn't array3_size() correctly line wrapped?
I think that line breaking only works on the outermost function call.
julia
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci
