On 2/16/19 7:00 AM, Markus Elfring wrote:
>> The generic transformation is simple but perfect at the same time and
>> showcases coccinelles expressiveness and beauty.
>
> Another “false positive leftover” pointed further software development
> opportunities out according to your suggestion “[PATCH] oleaut32/tests:
> Propagate the const instead of casting it away”, didn't it?
> https://source.winehq.org/patches/data/158631
???
a.) That patch is not a cast to self so no "further software development
opportunities" to my selfcast.cocci script.
b.) Actually doing code cleanup is a better way of finding new
"opportunities" for more cleanup. The vague hints for "further software
development opportunities" are actually harmful as they add noise and
detract from the bug report.
bye
michael
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
