On Wed, 25 Sep 2019, Michele Martone wrote:
> One may think that when warning that
> "should %s be a metavariable?"
> Coccinelle also treats a given symbol %s as a metavariable.
> Better state explicitly that this is not the case.
The change is ok. Please add a Signed-off-by:
thanks,
julia
> ---
> parsing_cocci/check_meta.ml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/parsing_cocci/check_meta.ml b/parsing_cocci/check_meta.ml
> index e728d8f5..b857d3f6 100644
> --- a/parsing_cocci/check_meta.ml
> +++ b/parsing_cocci/check_meta.ml
> @@ -84,7 +84,7 @@ let rec ident context old_metas table minus i =
> not err(* warn only once per id *) && not info.Ast0.isSymbolIdent
> then
> warning
> - (Printf.sprintf "line %d: should %s be a metavariable?" rl name)
> + (Printf.sprintf "line %d: should %s be a metavariable? treating
> it as symbol." rl name)
> | _ -> ())
> | Ast0.MetaId(name,_,seedval,_) ->
> check_table table minus name;
> --
> 2.20.1
>
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
