On Fri, 18 Oct 2019, Markus Elfring wrote:
> > expression *y;
>
> This specific information is interesting.
>
> It was mentioned that further software development concerns
> can occur around the possible application of function pointers.
> Now I would like to point another analysis concern out.
>
> The following SmPL search approach does not present the source code place
>
> @display@
> expression* x, y;
> @@
> *y = (x)(...);
> ... when != y
device_link_add does not look like a function pointer.
julia
>
>
> which can found by an other script variant for further considerations.
>
> @display@
> expression x;
> @@
> *x = device_link_add(...);
> ... when != x
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=c4b9850b3676869ac0def5885d781d17f64b3a86#n1057
>
> elfring@Sonne:~/Projekte/Linux/next-patched> spatch
> drivers/iommu/rockchip-iommu.c
> ~/Projekte/Coccinelle/janitor/show_unchecked_device_link_add1.cocci
> …
> @@ -1072,8 +1072,6 @@ static int rk_iommu_add_device(struct de
> iommu_group_put(group);
>
> iommu_device_link(&iommu->iommu, dev);
> - data->link = device_link_add(dev, iommu->dev,
> - DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME);
>
> return 0;
> }
>
>
> Would you like to check the desired data processing in more detail then?
>
> Regards,
> Markus
>
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci
