Hi,
we changed our allocator (wrapper) function to assert() instead of returning
ISC_R_MEMORY.
As you can imagine there’s a lot of checks down the road that needs to be
cleaned up,
so I am looking for a way to detect function that only does:
isc_result_t
foo(…) {
…
return (ISC_R_SUCCESS);
}
it could possibly be:
isc_result_t
foo(…) {
…
return (ISC_R_SUCCESS);
…
return (ISC_R_SUCCESS);
}
Looking at badcheck.cocci, it looks like I just need a block that would „match“
such functions,
but I can’t find a solid example on how to write a patch that would express:
Mark functions that just return ISC_R_SUCCESS and nothing else:
Something like this:
@match_rule@
expression E;
@@
<+... when != E != ISC_R_SUCCESS;
return (E);
...+>
@depends on match_rule@
@@
- return(...);
+ return;
But that doesn’t work for me, it matches all return()s.
Thanks,
Ondrej
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci
