Hello, I would like to clarify the following source code analysis result which can be provided by the tool “coccicheck”.
./drivers/bus/ti-sysc.c:1776:2-8: ERROR: missing clk_put; clk_get on line 1767 and execution via conditional on line 1775 ./drivers/tty/serial/bcm63xx_uart.c:851:2-8: ERROR: missing clk_put; clk_get on line 846 and execution via conditional on line 850 I have got the impression that false positives are reported for the implementations of the functions “sysc_child_add_named_clock” and “bcm_uart_probe” so far because variable assignment exclusions were not specified as when constraints for the involved script for the semantic patch language. https://elixir.bootlin.com/linux/v5.4-rc5/source/drivers/bus/ti-sysc.c#L1784 https://elixir.bootlin.com/linux/v5.4-rc5/source/drivers/tty/serial/bcm63xx_uart.c#L811 How do you think about it? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccinelle/free/clk_put.cocci?id=26bc672134241a080a83b2ab9aa8abede8d30e1c#n2 Regards, Markus _______________________________________________ Cocci mailing list [email protected] https://systeme.lip6.fr/mailman/listinfo/cocci
