On Mon, 14 Sep 2020, Markus Elfring wrote:
> >> How do you think about to use the following check variant?
> >>
> >> + if [ "${DEBUG_FILE}" != '/dev/null' -a "${DEBUG_FILE}" != '' ]; then
> >
> > What difference does it make?
>
> I propose two implementation details for further development considerations.
>
> 1. Do you care if any variable names should be enclosed by curly brackets
> in such script code?
>
> 2. A changeable value should be compared to two string literals here.
> Varying contents should be enclosed by double quotes.
> Constant values can be enclosed by single quotes, can't they?
I have no idea. Why can't they be nclosed by double quotes as well?
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
