> mac = of_get_mac_address(np); > if (!IS_ERR(mac)) > ether_addr_copy(ndev->dev_addr, mac); > > This would need to be changed to: > > of_get_mac_address(np, ndev->dev_addr);
Can such a function call variant fail? How do you think about take any special return values into account? > Maybe (well I'm sure) there is something to improve here. I suggest once more to group another bit of SmPL code like “+ ret_tbd = …” by using nested SmPL disjunctions so that duplicate specifications can be reduced. Regards, Markus _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
