Hi Bing,

Looks good. One comment though: I would return nil instead of an empty string 
to differentiate an actual value (the empty string) vs. "nothing was read."

-- Tito

On Jun 12, 2011, at 11:29 AM, Bing Li wrote:

> Dear all,
> 
> Do you think the below method is a correct solution to manage memory? I am
> not sure if the array, nodes, could leak?
> 
> Thanks so much!
> 
> Best regards,
> Bing
> 
> + (NSString *)read:(NSString *)xml Path:(NSString *)xPath
> {
>        NSXMLDocument *xmlDoc = [[NSXMLDocument alloc] initWithXMLString:xml
> options:NSXMLDocumentTidyXML error:NULL];
>        NSArray *nodes = [xmlDoc nodesForXPath:xPath error:NULL];
>        [xmlDoc release];
>        if ([nodes count] > 0)
>        {
>                return [[nodes objectAtIndex:0] stringValue];
>        }
>        else
>        {
>                return @"";
>        }
> }
> _______________________________________________
> 
> Cocoa-dev mailing list ([email protected])
> 
> Please do not post admin requests or moderator comments to the list.
> Contact the moderators at cocoa-dev-admins(at)lists.apple.com
> 
> Help/Unsubscribe/Update your Subscription:
> http://lists.apple.com/mailman/options/cocoa-dev/tciuro%40mac.com
> 
> This email sent to [email protected]

_______________________________________________

Cocoa-dev mailing list ([email protected])

Please do not post admin requests or moderator comments to the list.
Contact the moderators at cocoa-dev-admins(at)lists.apple.com

Help/Unsubscribe/Update your Subscription:
http://lists.apple.com/mailman/options/cocoa-dev/archive%40mail-archive.com

This email sent to [email protected]

Reply via email to