cziegeler 2003/04/27 08:16:16
Modified: src/deprecated/java/org/apache/cocoon/components/store
MRUMemoryStore.java JispFilesystemStore.java
src/deprecated/java/org/apache/cocoon/components/xslt
XSLTProcessorImpl.java
src/deprecated/java/org/apache/cocoon/components/source
AbstractStreamSource.java
src/deprecated/java/org/apache/cocoon/environment
WriteableSource.java
src/deprecated/java/org/apache/cocoon/components/parser
JaxpParser.java
Log:
Removing from TODOs and FIXMEs from deprecated code
Revision Changes Path
1.2 +1 -4
cocoon-2.1/src/deprecated/java/org/apache/cocoon/components/store/MRUMemoryStore.java
Index: MRUMemoryStore.java
===================================================================
RCS file:
/home/cvs/cocoon-2.1/src/deprecated/java/org/apache/cocoon/components/store/MRUMemoryStore.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- MRUMemoryStore.java 9 Mar 2003 00:07:07 -0000 1.1
+++ MRUMemoryStore.java 27 Apr 2003 15:16:15 -0000 1.2
@@ -342,8 +342,6 @@
/**
* This method checks if an object is seriazable.
- * FIXME: In the moment only CachedEventObject or
- * CachedStreamObject are stored.
*
* @param object The object to be checked
* @return true if the object is storeable
@@ -354,7 +352,6 @@
try {
String clazz = object.getClass().getName();
- // FIXME (VG): Can class identity check work here (==)? It will
be faster.
if((clazz.equals("org.apache.cocoon.caching.CachedEventObject"))
||
(clazz.equals("org.apache.cocoon.caching.CachedStreamObject"))
|| (ClassUtils.implementsInterface(clazz,
"org.apache.cocoon.caching.CacheValidity"))) {
1.2 +2 -4
cocoon-2.1/src/deprecated/java/org/apache/cocoon/components/store/JispFilesystemStore.java
Index: JispFilesystemStore.java
===================================================================
RCS file:
/home/cvs/cocoon-2.1/src/deprecated/java/org/apache/cocoon/components/store/JispFilesystemStore.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- JispFilesystemStore.java 9 Mar 2003 00:07:06 -0000 1.1
+++ JispFilesystemStore.java 27 Apr 2003 15:16:15 -0000 1.2
@@ -335,10 +335,9 @@
/**
* Frees some values of the data file.<br>
- * TODO: implementation
*/
public synchronized void free() {
- //TODO: implementation
+ // implementation is missing
}
/**
@@ -434,7 +433,6 @@
* @return the wrapped key object
*/
private KeyObject wrapKeyObject(Object key) {
- // TODO: Implementation of Integer and Long keys
return new JispStringKey(String.valueOf(key));
}
1.2 +3 -3
cocoon-2.1/src/deprecated/java/org/apache/cocoon/components/xslt/XSLTProcessorImpl.java
Index: XSLTProcessorImpl.java
===================================================================
RCS file:
/home/cvs/cocoon-2.1/src/deprecated/java/org/apache/cocoon/components/xslt/XSLTProcessorImpl.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- XSLTProcessorImpl.java 9 Mar 2003 00:07:12 -0000 1.1
+++ XSLTProcessorImpl.java 27 Apr 2003 15:16:15 -0000 1.2
@@ -287,7 +287,7 @@
if (getLogger().isDebugEnabled())
this.getLogger().debug("XSLTProcessorImpl: starting
transform");
- // FIXME (VG): Is it possible to use Source's toSAX method?
+ // Is it possible to use Source's toSAX method?
handler.setResult(result);
source.toSAX(handler);
@@ -335,7 +335,7 @@
_factory.setErrorListener(this.errorHandler);
_factory.setURIResolver(this);
- // FIXME (SM): implementation-specific parameter passing should be
+ // implementation-specific parameter passing should be
// made more extensible.
if
(_factory.getClass().getName().equals("org.apache.xalan.processor.TransformerFactoryImpl"))
{
_factory.setAttribute("http://xml.apache.org/xalan/features/incremental";,
1.3 +1 -4
cocoon-2.1/src/deprecated/java/org/apache/cocoon/components/source/AbstractStreamSource.java
Index: AbstractStreamSource.java
===================================================================
RCS file:
/home/cvs/cocoon-2.1/src/deprecated/java/org/apache/cocoon/components/source/AbstractStreamSource.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- AbstractStreamSource.java 16 Mar 2003 17:49:10 -0000 1.2
+++ AbstractStreamSource.java 27 Apr 2003 15:16:15 -0000 1.3
@@ -97,8 +97,6 @@
*/
public abstract class AbstractStreamSource extends AbstractLogEnabled
implements ModifiableSource {
-// FIXME(SW) : this implements *Modifiable*Source just to call refresh()
-// if JTidy fails. Can we avoid this ?
/** Is JTidy available? */
private static Class jtidyClass;
@@ -153,7 +151,6 @@
InputStream stream = this.getInputStream();
if (jtidyClass != null && isHTMLContent()) {
try {
- // FIXME (CZ) we need to speed up this!
final Object xhtmlconvert = jtidyClass.newInstance();
Method m = jtidyClass.getMethod("setXmlOut", new Class[] {
Class.forName("java.lang.Boolean")});
m.invoke(xhtmlconvert, new Object[] { new Boolean(true) });
1.2 +1 -4
cocoon-2.1/src/deprecated/java/org/apache/cocoon/environment/WriteableSource.java
Index: WriteableSource.java
===================================================================
RCS file:
/home/cvs/cocoon-2.1/src/deprecated/java/org/apache/cocoon/environment/WriteableSource.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- WriteableSource.java 9 Mar 2003 00:07:13 -0000 1.1
+++ WriteableSource.java 27 Apr 2003 15:16:15 -0000 1.2
@@ -80,9 +80,6 @@
*/
public interface WriteableSource extends ModifiableSource {
-//FIXME(SW) : should this be also Parameterizable to accept more parameters
-// such as user/password, headers, etc ?
-
/**
* Does this source actually exist ?
*
1.2 +1 -5
cocoon-2.1/src/deprecated/java/org/apache/cocoon/components/parser/JaxpParser.java
Index: JaxpParser.java
===================================================================
RCS file:
/home/cvs/cocoon-2.1/src/deprecated/java/org/apache/cocoon/components/parser/JaxpParser.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- JaxpParser.java 9 Mar 2003 00:06:57 -0000 1.1
+++ JaxpParser.java 27 Apr 2003 15:16:16 -0000 1.2
@@ -182,8 +182,6 @@
throw new ParameterException("Cannot load SAXParserFactory
class " + className, e);
}
}
- // FIXME(VG): This always prints "SAXParserFactory: null"
- // getLogger().debug("SAXParserFactory: " +
ClassUtils.which(factory.getClass()));
factory.setNamespaceAware(true);
factory.setValidating(validate);
@@ -200,8 +198,6 @@
throw new ParameterException("Cannot load
DocumentBuilderFactory class " + className, e);
}
}
- // FIXME(VG): This always prints "DocumentBuilderFactory: null"
- // getLogger().debug("DocumentBuilderFactory: " +
ClassUtils.which(docFactory.getClass()));
docFactory.setNamespaceAware(true);
docFactory.setValidating(validate);
