Hi Christian,
I just looked through your draft and think it is really a very good
documentation for beginners.
Here are some comments, so that we get the XML version ;-)
1.) In the second chapter you have this example:
<map:match pattern="*/*/*?user=*">
As the WildcardURIMatcher does only match against the url
without the parameter that match doesn't work. This match
does not match for any request as the '?' is not a
character allowed in the url.
For matching parameters you should use other matchers.
2.) Second chapter:
> Actions should be used to "do" something, not to chose between
> different sub pipelines. That should be done only, if an error occurred
> and you cannot continue the regular pipeline.
I think this is to restrictive. For example an authentication action
tests if the current client is authenticated and decides what to do.
If you are not authenticated, the "sub pipeline" is not invoked, but
I won't call this an error.
3.)
> If you would like to do global configuration for your matcher, it has
> to implement the
> org.apache.avalon.framework.configuration.Configurable,
> org.apache.avalon.framework.thread.ThreadSafe, and
> org.apache.avalon.framework.component.Component interfaces.
>
> (not sure about this, is it really necessary to implement all three of
> them?)
No, Configurable is only needed if your component has a configuration,
like the browser selector. Component is needed as this is an Avalon
component.
I am not sure quiet sure if ThreadSafe is required for matchers and
selectors. It is required for Actions. ThreadSafe indicates that
this component can be used parallel by several threads.
(For more information on these interfaces refer to the avalon site).
Carsten
Open Source Group sunShine - b:Integrated
================================================================
Carsten Ziegeler, S&N AG, Klingenderstrasse 5, D-33100 Paderborn
www.sundn.de mailto: [EMAIL PROTECTED]
================================================================
> -----Ursprungliche Nachricht-----
> Von: Christian Haul [mailto:[EMAIL PROTECTED]]
> Gesendet: Mittwoch, 27. Juni 2001 16:35
> An: [EMAIL PROTECTED]
> Betreff: [C2] docs: draft on matchers and selectors
>
>
> Hi.
>
> I have written down what I was able to figure out on matchers and
> selectors. Please comment. Especially, if you happen to have
> implemented this stuff :-)
>
> I will XMLize it to match the other docs after the first round of
> comments. (no comments, no XML ;-)
>
> Speaking of comments, there are currently two of my patches still
> neither commented, rejected nor applied. And I'm sitting on two more...
>
> Chris.
>
> --
> C h r i s t i a n H a u l
> [EMAIL PROTECTED]
> fingerprint: 99B0 1D9D 7919 644A 4837 7D73 FEF9 6856 335A 9E08
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
