On 19.Jul.2001 -- 11:06 PM, giacomo wrote:
> I totally agree with you, Sylvain, and would encourage Christian to
> remove the hole configuration part from the AbstractAction at all
> because this forces new developer to think of using parameter
> elements instead of better ones like <foo>bar</foo>.
I found that actions could be easier to use when some parameters could
be specified that are valid for all invocations. For example one might
want to have all validator actions use the same descriptor file, or
all database actions use the same connection, or ...
Before, it was necessary to specify this for every invocation. I think
that makes the sitemap less readable. Action sets are a solution to
this only, if the success of an action is of no importance to the rest
of the pipeline or this is communicated through side channels like
modifying the request object.
Hence, I believe that all actions should be able to receive the same
configuration information for sitemap wide use that they take per
invokation.
If we can agree on this, it would be a duplication of effort to have
every action implement parsing the configuration itself. This is the
reason why I suggested to put this into AbstractAction.
Would you prefer to have another abstract action, that contains some
configuration support?
Sylvain is right about the map:parameter part. We could modify the
configuration method so that it takes every node name as key and the
node value as er value.
Example:
<map:action name="form-validator" src="org.apache.cocoon.acting.FormValidatorAction">
<map:parameter name="descriptor" value="context://descriptor.xml"/>
</map:parameter>
becomes
<map:action name="form-validator" src="org.apache.cocoon.acting.FormValidatorAction">
<descriptor>context://descriptor.xml</descriptor>
</map:parameter>
I would modify the code to what we agree upon, but I understood
Sylvain that he already did this and didn't want to duplicate it.
Chris.
--
C h r i s t i a n H a u l
[EMAIL PROTECTED]
fingerprint: 99B0 1D9D 7919 644A 4837 7D73 FEF9 6856 335A 9E08
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
