Hello,

May I suggest this little patch? The way it was indented confused the
heck out of me. I spent several minutes trying to understand what
effect call to this.getConfigFile has. If you don't pay attention to
parentheses it looks as if the result of the call is discarded.

Thanks
Greg
Index: CocoonServlet.java
===================================================================
RCS file: 
/home/cvspublic/xml-cocoon2/src/org/apache/cocoon/servlet/CocoonServlet.java,v
retrieving revision 1.13.2.30
diff -c -r1.13.2.30 CocoonServlet.java
*** CocoonServlet.java  2001/10/23 11:38:44     1.13.2.30
--- CocoonServlet.java  2001/10/25 02:30:52
***************
*** 171,177 ****
          this.cacheDir.mkdirs();
  
          this.appContext.put(Constants.CONTEXT_CONFIG_URL,
!         this.getConfigFile(conf.getInitParameter("configurations")));
          if(conf.getInitParameter("configurations") == null) {
             log.debug("configurations was not set - defaulting to... ?");
          }
--- 171,177 ----
          this.cacheDir.mkdirs();
  
          this.appContext.put(Constants.CONTEXT_CONFIG_URL,
!                             
this.getConfigFile(conf.getInitParameter("configurations")));
          if(conf.getInitParameter("configurations") == null) {
             log.debug("configurations was not set - defaulting to... ?");
          }

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

Reply via email to