Hi Gerhard, thanks for your patch! But - sorry for this pain - I think we should not change existing interfaces like the Store interface. The MRUMemoryStore calls the keys() method of the FilesystemStore. The fsstore returns all keys, but only those contained in a special directory are of interest. What do you think of filtering the keys() delivered by the fsstore in the MRUMemoryStore? I know this is slow but would allow us to keep the interface. In addition the keys() method of the fsstore is wrong as it doesn't go into directories. I will fix this asap.
Carsten Gerhard Froehlich wrote: > > > Hi, > as promised this patch contains serveral fixes > in the store implementation: > > MRUMemoryStore: > - added Disposable interface and implemented > the initialize() and dispose() method to init- > ialize/dispose the StoreJanitor and the FilesystemQueue > thread. > - completed the methods containsKey() and keys() > (I needed to extend the Store interface and the > FilesystemStore too) > > StoreJanitor: > - added the Startable interface and implemented > start() and stop() to start/stop the checker > thread > > FileSystemQueue: > - added the Startable interface and implemented > start() and stop() to start/stop the writer > thread > > Cheers > Gerhard > -------------------------------------------- > black holes are when GOD is dividing by zero > 23 49 43 51 3A 20 31 32 33 35 33 34 38 31 31 > -------------------------------------------- --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
