Sylvain, >From: Sylvain Wallez [mailto:[EMAIL PROTECTED]] > > >Gerhard Froehlich a écrit : >> >> Hi, >> I implemented the Excalibur Resource Monitor into >> Cocoon.java. The Resource Monitor observes now >> the cocoon.xconf file and notifies Cocoon.java, >> when the file has changed. >> >> Cheers >> Gerhard >> > >Sorry to be so annoying about resource and monitors, but from a design >point of view, I think using ActiveMonitor this way is overkill.
No problem, dude. False pride is unsuitable, searching for the most perfect solution is suitable! >As Berin said, the purpose of ActiveMonitor is to trigger some action >when a resource changes. Just changing the "lastModified" attribute >isn't IMO an action that justifies a background thread to periodically >monitor the filesystem. > >On the other hand, the FileResource with delayed call to >File.lastModified() I proposed yesterday (see >http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=100799905918225&w=2 ) >seems to me more appropriate in this case : > >- only Cocoon uses cocoon.xconf, and it already keeps the associated >Source object as an attribute. So there's no need to register it in a >centralized monitor. > >- like ActiveMonitor, it reduces the number of filesystem calls and >ensures the age of the "lastModified" information isn't greater that the >refresh period, but unlike ActiveMonitor, doesn't refresh it >unnecessarily at _every_ refresh period. > >Thoughts ? All your arguments above are correct. For the Cocoon.java the ActiveMonitor is overkill, but what do you want? The Cocoon.java was a starting point to implement a central Resource Monitoring to reduce our huge lastModified calls. Maybe Cocoon.java is not right Example for lastModified calls. But look into the piplines (even CachingxxxPiplines). Somebody has to start, I did. Which way shall we take? Is this an issue or not? That's my question now! If not we can stop here now. If yes then we should search for a solution which fits. <flame_point> Sometimes I've the feeling the devs here are so keen on integrating fancy and sexy new stuff into Cocoon that they forget the basis! </flame_point> If you want, I remove this stuff for now, but only for a clean reboot of this issue ;-). Cheers Gerhard ------------------------------------------------------------------ Calvin: People think it must be fun to be a super genius, but they don't realize how hard it is to put up with all the idiots in the world. Hobbes: Isn't your pants' zipper supposed to be in the front? ------------------------------------------------------------------ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
