Hi Mark, first, welcome as a new committer! (I totally forgot that you are new...)
Ok, I see the concern: a custom component should not take Cocoon down. But IMHO this is not possible to achieve. It requires to write components in a different way as we can see from the "moved" exception handling in the Deli component. So, I prefer reinstalling the former version where the exceptions are not catched but directly thrown. If Deli is misconfigured than someone has made a mistake and has to change this. The second version you send in is a little bit better in my eyes - but as you catch exceptions at a latter stage the real cause is not visible anymore. Ok, it's somewhere in the logs, but noone really looks through the whole log. But what do the other developers think? Carsten > Mark Butler wrote: > > > Hi Carsten > > Is this version better - I've just moved exception handling to cover calls > to DELI library? > > Mark > > > -----Original Message----- > > From: Butler, Mark [mailto:[EMAIL PROTECTED]] > > Sent: 05 February 2002 12:09 > > To: '[EMAIL PROTECTED]' > > Subject: RE: cvs commit: > > xml-cocoon2/src/java/org/apache/cocoon/components /deli DeliImpl.java > > > > > > Hi Carsten > > > > I was just trying to make sure that DELI doesn't take down > > Cocoon if it > > encounters an error (Berin's and Stefano's criticism) - > > errors should be > > logged as well. > > > > We can reinstate the previous code if you prefer? > > > > Mark > > > > > -----Original Message----- > > > From: Carsten Ziegeler [mailto:[EMAIL PROTECTED]] > > > Sent: 05 February 2002 11:38 > > > To: [EMAIL PROTECTED] > > > Subject: RE: cvs commit: > > > xml-cocoon2/src/java/org/apache/cocoon/components/deli DeliImpl.java > > > > > > > > > Hi Mark, > > > > > > I'm not sure if the exception handling introduced by this > > check-in is > > > really better. In my eyes its worse as now possible > > exceptions during > > > configuration and contextualization are ignored. > > > What do you think? > > > > > > Carsten > > > > > > > -----Original Message----- > > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > > > > Sent: Tuesday, February 05, 2002 11:11 AM > > > > To: [EMAIL PROTECTED] > > > > Subject: cvs commit: > > > > xml-cocoon2/src/java/org/apache/cocoon/components/deli > > DeliImpl.java > > > > > > > > > > > > butlermh 02/02/05 02:10:45 > > > > > > > > Modified: src/java/org/apache/cocoon/components/deli > > > DeliImpl.java > > > > Log: > > > > Added better exception handling. > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, email: [EMAIL PROTECTED] > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, email: [EMAIL PROTECTED] > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
