Hi Konstantin, Patch failed. Can you resend diff with the currect CVS?
Thanks, Vadim > -----Original Message----- > From: Piroumian, Konstantin [mailto:[EMAIL PROTECTED]] > Sent: Thursday, February 07, 2002 12:49 PM > To: [EMAIL PROTECTED] > Subject: Re: [Patch] Character handling in i18n transformer fix > > Good time of day again! > > I've fixed i18n transformer - now i18n samples work, also it'd be fine if > anybody could test pages where chunked character data happens. Now, I hope, > everything should be fine. > > I've change the implementation like as if a character filter is used - all > the chunked data is buffered until startElement or endElement event is > received. > > Bugzilla is still unaccessible from here, could anybody please apply this > final (until next bug is found) patch. > > Next step in i18n transformer improvement should be reducing the number of > debug messages. > > Regards, > Konstantin Piroumian > > > > It seems that I've made an hasty conclusion that everything's work - the > > cause was another Tomcat instance with the old C2 deployed ;(( > > > > Current version of i18n transformer does not handle i18n samples > correctly. > > The quick glance to the source showed that the problem is that the > > startI18NElement() does not handle previously buffered characters, e.g.: > > > > <i18n:translate> > > Some text <!-- we buffer the character data here > > <i18n:param ...> <!-- we get startElement() and the old buffer is > > replaced with a brand new one > > </i18n:translate> > > > > I'll try to fix it asap and hope will send a patch in an hour. > > > > Regards, > > Konstantin Piroumian > > > > > > Applied, please check. > > > > > > Thanks > > > > > > > > > > > I'm not sure about this trim() though: the result may be the words > > > > concatenated with each other without single space... > > > > > > Yes, that's true, I think that trim() should be used at the end only - > > when > > > looking for the translation. I'll fix it now. > > > > > > Konstantin > > > > > > > > > > > Vadim > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
