Sylvain Wallez wrote: > > Carsten Ziegeler wrote: > > >Hi, > > > >currently the TreeBuilderSelector is not a real Avalon Component, > >it is configured in an XML file called "treeprocessor-builtins.xml". > > > > <picky-mode> > What makes it not a real Avalon component that its class name is > hardcoded in TreeProcessor, not that its configuration isn't in > cocoon.xconf. Now is there a real need to have an alternate > implementation for this basic selector ? > </picky-mode> > Hm, I see one major difference: the TreeProcessor has to implement all life-cycle interfaces to get all information only to instantiate later on the selector. In my eyes this should not be the concern of the TreeProcessor.
> >Can we make a real avalon component out of this and move the > >configuration into the cocoon.xconf? > >I think this would reduce the code of the treeprocessor in some > >areas and make the configuration more consistent with the > >configuration of other components. > > > > The configuration of the pipeline languages is in a separate file > because designing/modifying a pipeline language is not a common task and > IMO doesn't belong to the usual system-assembly tasks handled by > cocoon.xconf. Also, I think adding these 160 lines of declarations won't > help frightened newbies to understand the big picture. > Ok, yes, this is right. But on the other hand there are many configurations in the cocoon.xconf which are absolutely not relevant for newbies and we don't want to create separate configurations files for these components only to make the cocoon.xconf smaller/simpler. > Nevertheless, the treeprocessor allows to name an alternate > configuration file using the "config" attribute recently added by > Ovidiu. If you want to, we can also allow the full treeprocessor > configuration to be present in cocoon.xconf. > Yes, I still feel that we should remove this attribute and put everything in the cocoon.xconf as I want to have on single point of configuration for components. What do others think? Carsten --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
